Skip to content

feat(identity): count anonymous sign-in and setup outcomes - #615

Merged
harlan-zw merged 1 commit into
mainfrom
feat/signup-funnel
Oct 10, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
feat/signup-funnel

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #612

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Account rows cannot explain which sign-in or setup step failed. Count anonymous entry paths and step outcomes in the daily check-in, including opt-outs and CLI token issuance.

Repeat visits count again, so the report measures attempts, not unique users. The privacy page explains these counts.

Sign-in and setup outcomes flow from fixed event labels to anonymous Analytics Engine counts and the daily check-in

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 10, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-10 13:38 UTC.

GitHub merged this pull request.

  • Logged (20/100): The only embedded PR diagram is unavailable, so the documented event-to-check-in flow cannot be visually verified against the implementation. View code Optional follow-up: Re-upload the diagram attachment and update the PR description.
    • Ask an agent to verify and fix this finding
  • Logged (40/100): One unexpected signup row hard-fails the entire daily analytics check, including command-copy evidence. View code Optional follow-up: Parse per row with safeParse, keep conforming rows, and surface dropped rows as evidence instead of throwing.
    • Ask an agent to verify and fix this finding
  • Logged (15/100): The privacy enumeration of counted sign-in steps omits the server-side CLI connection count. View code Optional follow-up: Extend the sign-in counts sentence to name CLI connection completion.
    • Ask an agent to verify and fix this finding
  • Logged (15/100): The copy-query pollution guard ships without a regression test pinning it. View code Optional follow-up: Add the containment assertion to the command copy analytics tests.
    • Ask an agent to verify and fix this finding

b1b007c5-e352-483f-85e3-3427048a4ac2

Selected findings run after merge and open separate pull requests.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 10, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent verification, outside CI:

  • A local signed-in fixture received a real HTTP 400 from the email settings API. The form showed the failure and stayed open. Retrying with a valid address completed setup. Both signup event requests returned HTTP 200.
  • The privacy page rendered at desktop width. Mobile pages had no horizontal overflow at 375px.
  • The production Analytics Engine SQL query returned HTTP 200 with no historical signup counts. This read-only query cannot verify event ingestion before deployment.

Privacy page explains anonymous step counts and their limits

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 10, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit 5d03c69 into main Oct 10, 2026
8 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 10, 2026
@harlan-zw
harlan-zw deleted the feat/signup-funnel branch October 10, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant