Repository navigation
Simplify the driver download - #26
Merged
Merged
Conversation
Since the driver is downloaded on first use, the progress output printed in the middle of the browsertime log. One line before and one after the download is enough. The archive is small, so it is downloaded into memory, which removes the stream handling. The npm_config skip variable only worked inside an npm install script, and the package no longer has one. The files list also named a shrinkwrap file that does not exist. Only the driver binary is extracted, so the license notes and credits from the archive are no longer kept and deleted afterwards. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the driver is downloaded on first use, the progress output printed in the middle of the browsertime log. One line before and one after the download is enough. The archive is small, so it is downloaded into memory, which removes the stream handling.
The npm_config skip variable only worked inside an npm install script, and the package no longer has one. The files list also named a shrinkwrap file that does not exist.
Only the driver binary is extracted, so the license notes and credits from the archive are no longer kept and deleted afterwards.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com