Repository navigation
Download Edgedriver on first use instead of at install - #25
Merged
Merged
Conversation
npm 11.20 warns about every dependency with an install script that the project has not approved, and a future npm release will block those scripts. Everyone who installs browsertime or sitespeed.io got that warning for Edgedriver, and users of a global install cannot approve the script from their side. The driver is now downloaded the first time it is needed, so the package has no install script and npm has nothing to warn about. Downloading at install time is still possible with node install.js, for Docker images and for machines that have no internet access during tests. CI now runs the driver after the download, because it no longer gets downloaded during npm ci. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm 11.20 warns about every dependency with an install script that the project has not approved, and a future npm release will block those scripts. Everyone who installs browsertime or sitespeed.io got that warning for Edgedriver, and users of a global install cannot approve the script from their side.
The driver is now downloaded the first time it is needed, so the package has no install script and npm has nothing to warn about. Downloading at install time is still possible with node install.js, for Docker images and for machines that have no internet access during tests. CI now runs the driver after the download, because it no longer gets downloaded during npm ci.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com