Repository navigation
Clean up templates, markup and docs - #177
Merged
Merged
Conversation
The page x-ray table repeated the same row markup for every metric, so a change to how one row looks had to be copied by hand to around twenty others. They now share one helper, and the rendered HTML is unchanged. Dead code from the Template7 and IE days is gone. Small fixes from the review: the request diff link in the header pointed at a misspelled anchor, the filmstrip had no header link, a HAR swapped in with Upload lost its file name, and Enter in the URL fields did nothing. The logos now have alt text, and the manifest works when the site runs under a sub-path. The README now describes the waterfall hover and the request diff as they really work, and its logo image is no longer broken. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page x-ray table repeated the same row markup for every metric, so a change to how one row looks had to be copied by hand to around twenty others. They now share one helper, and the rendered HTML is unchanged. Dead code from the Template7 and IE days is gone.
Small fixes from the review: the request diff link in the header pointed at a misspelled anchor, the filmstrip had no header link, a HAR swapped in with Upload lost its file name, and Enter in the URL fields did nothing. The logos now have alt text, and the manifest works when the site runs under a sub-path.
The README now describes the waterfall hover and the request diff as they really work, and its logo image is no longer broken.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com