Repository navigation
Add a Content-Security-Policy - #176
Merged
Merged
Conversation
Error messages and config comments are now plain text, but nothing stopped injected markup from running script if a new injection point appears. A CSP that allows only scripts from the site itself closes that whole class of bug. That meant moving the start-up code out of index.html and replacing the inline onclick/onchange/oninput handlers with data-action attributes and one delegated listener. HARs, screenshots and videos can still be loaded from any origin. A test fails if inline scripts or handlers come back. The obsolete X-XSS-Protection and FLoC opt-out headers are removed. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages and config comments are now plain text, but nothing stopped injected markup from running script if a new injection point appears. A CSP that allows only scripts from the site itself closes that whole class of bug.
That meant moving the start-up code out of index.html and replacing the inline onclick/onchange/oninput handlers with data-action attributes and one delegated listener. HARs, screenshots and videos can still be loaded from any origin. A test fails if inline scripts or handlers come back.
The obsolete X-XSS-Protection and FLoC opt-out headers are removed.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com