Skip to content

fix(magnetic sensor pwm): scale the pulseIn() timeout with the PWM frequency #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijncarelsbergh wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(magnetic sensor pwm): scale the pulseIn() timeout with the PWM frequency #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sensors/MagneticSensorPWM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ MagneticSensorPWM::MagneticSensorPWM(uint8_t _pinPWM, int freqHz, int _total_pwm

min_elapsed_time = 1.0f/freqHz; // set the minimum time between two readings

// scale the blocking read timeout with the PWM frequency: the high pulse can
// be almost a full period long (e.g. ~8.4ms at 115Hz) while the 1200us
// default only covers the fastest supported frequency (920Hz)
timeout_us = (unsigned int)(1.2f * 1000000.0f / freqHz);

// define as not set
last_call_us = _micros();
}
Expand Down