Repository navigation
fix(current sense): compare current magnitudes, not signed values - #575
Open
stijncarelsbergh wants to merge 1 commit into
Open
stijncarelsbergh wants to merge 1 commit into
stijncarelsbergh wants to merge 1 commit into
Conversation
Two flaws in the same alignment step: - the A-C branch compared `fabs(c.a) - fabs(c.c)` against a threshold without taking the absolute value of the difference, so a channel that reads *higher* than the driven phase passes the check instead of raising the error; - the B-C branch compared c.a with c.c (copy-paste from the branch above) while the message and the comment refer to phase B. (The same defect in the phase-B section no longer exists on dev, so it is not part of this change.)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(current sense): compare current magnitudes, not signed values
Two flaws in the same alignment step:
fabs(c.a) - fabs(c.c)against a threshold withouttaking the absolute value of the difference, so a channel that reads higher
than the driven phase passes the check instead of raising the error;
the message and the comment refer to phase B.
(The same defect in the phase-B section no longer exists on dev, so it is not
part of this change.)
Split out of #571 at your request: one fix per PR, against
dev. The branch containsnothing else, so it can be reviewed, amended or dropped on its own.
The CI board matrix runs automatically; I did not run any hardware test, so the behavioural
claims are from reading the code plus the compiler. Happy to adjust the wording, split it
differently or drop it - no attachment to this one.