Skip to content

SF-3795 Fix draft import dialog broken after locale change - #4231

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3795-dialog-direction-broken
Open

SF-3795 Fix draft import dialog broken after locale change#4231
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-3795-dialog-direction-broken

Conversation

@Nateowami

@Nateowami Nateowami commented Oct 24, 2026 •
edited by irahopkinson
Loading

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Oct 24, 2026
@Nateowami
Nateowami deployed to screenshot_diff October 24, 2026 03:37 — with GitHub Actions Active
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.20%. Comparing base (bc6f970) to head (abe9da5).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...aft-history-entry/draft-history-entry.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4231   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files         670      670           
  Lines       42913    42913           
  Branches     7105     7111    +6     
=======================================
  Hits        34846    34846           
  Misses       6902     6902           
  Partials     1165     1165

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added the ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes label Oct 24, 2026

This branch was successfully deployed

1 active deployment
screenshot_diff — abe9da5b Deployed Oct 24, 2026 by Nateowami via Compare Screenshots #1197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Nateowami