Skip to content

SF-3961 Hide project reference on feedback dialog unless required - #4227

Open
RaymondLuong3 wants to merge 1 commit into
masterfrom
fix/sf-3961-project-select
Open

RaymondLuong3 wants to merge 1 commit into
masterfrom
fix/sf-3961-project-select

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The feedback dialog now requires the project select to be filled in order to submit feedback. It also adds a flag so that the project reference can be hidden, and setting the project reference to be hidden makes that control in the form not required.

When the project reference is hidden
Feedback project not required


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.19%. Comparing base (bc6f970) to head (2020929).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pp/shared/user-feedback/user-feedback.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4227      +/-   ##
==========================================
- Coverage   81.20%   81.19%   -0.01%     
==========================================
  Files         670      670              
  Lines       42913    42920       +7     
  Branches     7105     7115      +10     
==========================================
+ Hits        34846    34849       +3     
- Misses       6902     6903       +1     
- Partials     1165     1168       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 deployed to screenshot_diff October 22, 2026 23:20 — with GitHub Actions Active
@RaymondLuong3 RaymondLuong3 added the ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes label Oct 23, 2026

This branch was successfully deployed

1 active deployment
screenshot_diff — 20209298 Deployed Oct 22, 2026 by RaymondLuong3 via Compare Screenshots #1174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant