Repository navigation
Conversation
Nateowami
reviewed
Oct 22, 2026
| return true; | ||
| } | ||
|
|
||
| // Only project admins may change editable properties. SF project docs have none, so this applies to any that are added. |
Collaborator
There was a problem hiding this comment.
The old comment is confusing, but is intended to justify why we have dead code here. I'm not sure just removing it is the best option.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## task/sec1-7 #4223 +/- ##
============================================
Coverage 81.20% 81.20%
============================================
Files 670 670
Lines 42920 42920
Branches 7116 7087 -29
============================================
Hits 34853 34853
- Misses 6902 6919 +17
+ Partials 1165 1148 -17 ☔ View full report in Codecov by Harness. |
The second part of the comment is awkward and unnecessarily adds maintenance to keep in sync if the editable props are edited in the future.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second part of the comment is awkward and unnecessarily adds
maintenance to keep in sync if the editable props are edited in the
future.
Open in Devin Review
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is