Skip to content

rts: Warn that a property domain has no ownerRef for hasRight - #4222

Open
marksvc wants to merge 1 commit into
task/sec1-6from
task/sec1-7
Open

marksvc wants to merge 1 commit into
task/sec1-6from
task/sec1-7

Conversation

@marksvc

@marksvc marksvc commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Every other branch of the update rules hands the rights check an
entity with
an owner, so it is easy to read this one as doing the same. It has the
potential to pass something other than an OwnedData as entity. A
domain whose path template ends in a property, as the answer status
domain
does, has the value of that property instead. This is not a problem
right now. This PR adds a comment to perhaps make it easier to figure
out why the rights aren't working upon trying to use them if this code
area is the problem.


Open in Devin Review


Stack created with GitHub Stacks CLI • Give Feedback 💬


This change is Reviewable

@marksvc
marksvc added this pull request to stack #4226 October 22, 2026 21:54
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (7ac6eea) to head (dacc865).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           task/sec1-6    #4222   +/-   ##
============================================
  Coverage        81.20%   81.20%           
============================================
  Files              670      670           
  Lines            42920    42920           
  Branches          7116     7116           
============================================
  Hits             34853    34853           
+ Misses            6919     6902   -17     
- Partials          1148     1165   +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@marksvc
marksvc deployed to screenshot_diff October 22, 2026 22:13 — with GitHub Actions Active
Every other branch of the update rules hands the rights check an
entity with
an owner, so it is easy to read this one as doing the same. It has the
potential to pass something other than an OwnedData as `entity`. A
domain whose path template ends in a property, as the answer status
domain
does, has the value of that property instead. This is not a problem
right now. This PR adds a comment to perhaps make it easier to figure
out why the rights aren't working upon trying to use them if this code
area is the problem.
@marksvc marksvc added testing not required ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes labels Oct 23, 2026
@marksvc
marksvc marked this pull request as ready for review October 23, 2026 16:08
@marksvc
marksvc removed this pull request from stack #4226 October 23, 2026 16:11
@marksvc
marksvc added this pull request to stack #4228 October 23, 2026 16:11
@marksvc
marksvc deployed to screenshot_diff October 23, 2026 16:14 — with GitHub Actions Active
@marksvc
marksvc deployed to screenshot_diff October 23, 2026 16:15 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
screenshot_diff — dacc865c Deployed Oct 23, 2026 by marksvc via Compare Screenshots #1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant