Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## task/sec1-6 #4222 +/- ##
============================================
Coverage 81.20% 81.20%
============================================
Files 670 670
Lines 42920 42920
Branches 7116 7116
============================================
Hits 34853 34853
+ Misses 6919 6902 -17
- Partials 1148 1165 +17 ☔ View full report in Codecov by Harness. |
Every other branch of the update rules hands the rights check an entity with an owner, so it is easy to read this one as doing the same. It has the potential to pass something other than an OwnedData as `entity`. A domain whose path template ends in a property, as the answer status domain does, has the value of that property instead. This is not a problem right now. This PR adds a comment to perhaps make it easier to figure out why the rights aren't working upon trying to use them if this code area is the problem.
marksvc
marked this pull request as ready for review
October 23, 2026 16:08
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other branch of the update rules hands the rights check an
entity with
an owner, so it is easy to read this one as doing the same. It has the
potential to pass something other than an OwnedData as
entity. Adomain whose path template ends in a property, as the answer status
domain
does, has the value of that property instead. This is not a problem
right now. This PR adds a comment to perhaps make it easier to figure
out why the rights aren't working upon trying to use them if this code
area is the problem.
Open in Devin Review
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is