Skip to content

rts test: Show that an array index is also not empty string or null - #4218

Open
marksvc wants to merge 1 commit into
task/sec1-2from
task/sec1-3
Open

marksvc wants to merge 1 commit into
task/sec1-2from
task/sec1-3

Conversation

@marksvc

@marksvc marksvc commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The test of what a path may index an array with covered a numeric string and a
word, but not the empty string or null, which JSON0 also turns into an index.


Open in Devin Review


Stack created with GitHub Stacks CLI • Give Feedback 💬


This change is Reviewable

@marksvc
marksvc added this pull request to stack #4226 October 22, 2026 21:54
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (beab9a9) to head (25099d2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           task/sec1-2    #4218   +/-   ##
============================================
  Coverage        81.20%   81.20%           
============================================
  Files              670      670           
  Lines            42920    42920           
  Branches          7116     7116           
============================================
  Hits             34853    34853           
+ Misses            6919     6902   -17     
- Partials          1148     1165   +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@marksvc
marksvc deployed to screenshot_diff October 22, 2026 22:08 — with GitHub Actions Active
@marksvc marksvc added testing not required ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes labels Oct 22, 2026
@marksvc
marksvc marked this pull request as ready for review October 22, 2026 22:51
@marksvc
marksvc removed this pull request from stack #4226 October 23, 2026 16:11
@marksvc
marksvc added this pull request to stack #4228 October 23, 2026 16:11
@marksvc
marksvc deployed to screenshot_diff October 23, 2026 16:12 — with GitHub Actions Active
The test of what a path may index an array with covered a numeric string and a
word, but not the empty string or null, which JSON0 also turns into an index.
@pmachapman
pmachapman deployed to screenshot_diff October 27, 2026 22:44 — with GitHub Actions Active
@pmachapman
pmachapman self-requested a review October 27, 2026 23:17
@pmachapman pmachapman self-assigned this Oct 27, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on marksvc).

This branch was successfully deployed

1 active deployment
screenshot_diff — 25099d22 Deployed Oct 27, 2026 by pmachapman via Compare Screenshots #1218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants