Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4216 +/- ##
=======================================
Coverage 81.20% 81.20%
=======================================
Files 670 670
Lines 42913 42913
Branches 7111 7111
=======================================
Hits 34846 34846
Misses 6902 6902
Partials 1165 1165 ☔ View full report in Codecov by Harness. |
marksvc
marked this pull request as ready for review
October 22, 2026 22:48
pmachapman
approved these changes
Oct 27, 2026
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on marksvc).
The note about what an update rule receives sat on allowUpdate itself, where an editor shows it when hovering the method rather than the argument it describes. It now sits on the argument, which is what a rule author is looking at when they need it. The wording also claimed the ops are the op as the client sent it, which is not so: ShareDB transforms a client's op against any ops that the client did not have before the update rules run, so paths, values and metadata can all differ from what was sent.
pmachapman
force-pushed
the
task/sec1-1
branch
from
October 27, 2026 22:35
869c901 to
a51915b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note about what an update rule receives sat on allowUpdate itself, where
an editor shows it when hovering the method rather than the argument it
describes. It now sits on the argument, which is what a rule author is looking
at when they need it.
The wording also claimed the ops are the op as the client sent it, which is not
so: ShareDB transforms a client's op against any ops that the client did not
have before the update rules run, so paths, values and metadata can all differ
from what was sent.
Open in Devin Review
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is