Repository navigation
Use expanded image tags in the fleet deploy step - #1858
Merged
Merged
Conversation
The image-tag-* inputs contain shell substitutions like $(date +%Y%m%d). The old kubectl step ran in a shell and expanded them; the yq step passes inputs verbatim, so the first fleet deploy wrote the literal "develop-$(date +%Y%m%d)-<sha>" into the staging kustomization. The integrate job already expands the inputs when it writes them to $GITHUB_OUTPUT, so expose TAG_APP/TAG_PROXY/TAG_NEXT_APP as job outputs and have deploy use those, matching the tags actually pushed to Docker Hub. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image-tag-* inputs contain shell substitutions like$(date +%Y%m%d). The old kubectl step ran in a shell and expanded them; the yq step passes inputs verbatim, so the first fleet deploy wrote the literal "develop-$ (date +%Y%m%d)-" into the staging kustomization.
The integrate job already expands the inputs when it writes them to $GITHUB_OUTPUT, so expose TAG_APP/TAG_PROXY/TAG_NEXT_APP as job outputs and have deploy use those, matching the tags actually pushed to Docker Hub.
Fixes #issue
Description
A summary of the change including motivation and context.
Screenshots
Demonstrate any UI / behavioral changes with screenshots or animations.
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
Describe how to verify your changes and provide any necessary test data.