Skip to content

Use expanded image tags in the fleet deploy step - #1858

Merged
hahn-kev merged 1 commit into
developfrom
fleet-deploy-tags
Oct 22, 2026
Merged

hahn-kev merged 1 commit into
developfrom
fleet-deploy-tags

Conversation

@hahn-kev

Copy link
Copy Markdown
Collaborator

The image-tag-* inputs contain shell substitutions like $(date +%Y%m%d). The old kubectl step ran in a shell and expanded them; the yq step passes inputs verbatim, so the first fleet deploy wrote the literal "develop-$(date +%Y%m%d)-" into the staging kustomization.

The integrate job already expands the inputs when it writes them to $GITHUB_OUTPUT, so expose TAG_APP/TAG_PROXY/TAG_NEXT_APP as job outputs and have deploy use those, matching the tags actually pushed to Docker Hub.

Fixes #issue

Description

A summary of the change including motivation and context.

Screenshots

Demonstrate any UI / behavioral changes with screenshots or animations.

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

Describe how to verify your changes and provide any necessary test data.

  • Test A

The image-tag-* inputs contain shell substitutions like $(date +%Y%m%d).
The old kubectl step ran in a shell and expanded them; the yq step passes
inputs verbatim, so the first fleet deploy wrote the literal
"develop-$(date +%Y%m%d)-<sha>" into the staging kustomization.

The integrate job already expands the inputs when it writes them to
$GITHUB_OUTPUT, so expose TAG_APP/TAG_PROXY/TAG_NEXT_APP as job outputs
and have deploy use those, matching the tags actually pushed to Docker Hub.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@hahn-kev
hahn-kev merged commit a8a08cd into develop Oct 22, 2026
14 of 15 checks passed
@hahn-kev
hahn-kev deleted the fleet-deploy-tags branch October 22, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant