Repository navigation
Port 'Quiet the Claude review and make local_check fail on any step' from machine.py - #545
Conversation
Follow-up the PR body already names: Public API, target framework, package: None verified. Parity with Findings: F1 new, unverified. Reviewed at 4789951 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
=======================================
Coverage 74.38% 74.38%
=======================================
Files 456 456
Lines 38343 38343
Branches 5264 5264
=======================================
Hits 28522 28522
Misses 8665 8665
Partials 1156 1156 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4789951 to
115b5bc
Compare
local_check.sh now runs every step, even after one fails. The last line names the steps that failed, so a build failure cannot hide behind a passing test run. Co-authored-by: Eli C. Lowry <83078660+Enkidu93@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This ports the rest of sillsdev/machine.py#409 for #544. The review now skips a push when the diff matches the last reviewed commit. It cites CI results from gh pr checks, and it posts a one-line summary when a round has no new findings. Agents now report the last line of local_check.sh instead of a test count. I did not port the rule for upstream defects. In machine.py, it skips defects that are shared with the C# code. In this repo, the C# code is the reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
machine.py does not have HermitCrab, so these PRs have nothing to port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
115b5bc to
75e401c
Compare
A defect that a PR shares with the machine.py code it ports or matches gets its own fix. The review names it in the summary and does not post it as a finding. Changes can start in either repo, so the rule applies here too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion.
Quick summary
local_check.sh now fails when any step fails, and its last line names the failed steps. The Claude review no longer runs again on a rebase that leaves the changes the same. Nothing in
src/ortests/changes.Where to look
changesjob compares the PR's diff at the lastReviewed atcommit with the diff at the head. It skips the review only when the two match.gh pr checks. It posts a one-line summary when a round has no new findings.Hermit Crablabel no longer create a porting issue in machine.py. machine.py does not have HermitCrab.Validation
./local_check.sh --agent-strict--local_check: PASSEDgit diff --check origin/master...HEAD-- cleanchangesjob ran on this PR and passed. The other workflow changes have not run yet.Issue / porting context
Ports sillsdev/machine.py#409. Closes #544.
🤖 Generated with Claude Code
This change is