Port 'Fix unclosed style marker crash' #502

Activity

1. Enkidu93

   added

   portingThis issue consists of porting code from machine.py to machine.This issue consists of porting code from machine.py to machine.

   on Sep 14, 2026
2. github-project-automation

   added this to Servalon Sep 14, 2026
3. github-project-automation

   moved this to 🆕 New in Servalon Sep 14, 2026
4. Enkidu93

   moved this from 🆕 New to 🔖 Ready in Servalon Sep 17, 2026
5. Enkidu93 commented on Oct 7, 2026

   

   Enkidu93

   on Oct 7, 2026

   CollaboratorAuthor

   More actions

   @claude Please address this issue.
6. Enkidu93

   self-assigned this

   on Oct 7, 2026
7. claude commented on Oct 7, 2026

   

   claudeBot

   on Oct 7, 2026 – with Claude

   Last edited by claude

   Contributor

   More actions

   Claude finished @Enkidu93's task in 5m 41s —— View job • claude/issue-502-20261007-1923 • [Create PR ➔](https://github.com/sillsdev/machine/compare/master...claude/issue-502-20261007-1923?quick_pull=1&title=Issue%20%23502%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23502%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

   ---

   Port of machine.py#364 is done

   PR: #536

   • Read the porting issue and the source PR
   • Port the parser handler fixes: EndChar leaves the token after an implicitly closed style alone, and EndNote skips the end marker in a duplicate verse
   • Port the placement handler fixes: it returns the block when there is nothing to insert, Other elements no longer break end-of-block handling, and verse ranges read every text token (GetText, IsPlaceable)
   • Port the tests
   • ./local_check.sh --agent-strict: comment hygiene clean, build succeeded, no failing tests

   Test change to review: the existing UpdateUsfm_VerseRanges test failed after the fix. It built six rows that each carried the full text, so every row's text was written out. I changed it to one row spanning MAT 1:1-5, as in machine.py.

   Not ported:

   • Moving the behavior enums into their own file. That fixes a Python circular import and has no C# counterpart.
   • Two machine.py tests: the milestone/embed placement test and the marker-behavior-disagrees test.
     · branch claude/issue-502-20261007-1923
8. Enkidu93

   closed this as completedin #536on Oct 13, 2026
9. github-project-automation

   moved this from 👀 In review to ✅ Done in Servalon Oct 13, 2026