Repository navigation
Port 'Convert USFM versification' #369
Description
Port any relevant changes in sillsdev/machine#472 from machine to machine.py.
Metadata
Metadata
Assignees
Type
Projects
- Status
{{ message }}
Port any relevant changes in sillsdev/machine#472 from machine to machine.py.
Activity
Enkidu93 commentedon Sep 29, 2026
@claude Please put in a PR to address this porting issue. Also, port the changes in #382 in the same PR.
claude commentedon Sep 29, 2026
Claude finished @Enkidu93's task in 17s —— View job
Blocked: can't read the source PR or issue #382
I haven't made any changes or opened a PR.
To port this I need the diff of sillsdev/machine#472 and the body of #382. Both reads were denied in this run:
gh pr diff 472 --repo sillsdev/machineandgh issue view 382needed approval, and none was granted.WebFetchfor the PR diff and for issue Port 'Fix double mappings handling and expand trailing paragraph marker definition' #382 also wasn't permitted.I didn't want to guess at the C# changes or at what #382 asks for. A guessed port of USFM versification handling could ship defects.
To unblock, either:
gh pr view,gh pr diffandgh issue view(andWebFetchfor github.com) to--allowedTools, then re-mention me. Or:Once I can read them, I'll follow the port-pr steps. That means porting the relevant changes and tests and running
./local_check.sh --agent-strict. Then I'll push the branch and give you a prefilled PR link.· Branch:
claude/issue-369-20260929-2053Enkidu93 commentedon Sep 29, 2026
@ddaspit - would it be possible to update claude's permissions to enable it to do this sort of thing?
ddaspit commentedon Sep 29, 2026
Yes. I'm currently working on the code review action, which is busy spamming poor Peter with duplicate comments on his PR. I will try to update the other action as well.
Enkidu93 commentedon Sep 30, 2026
@claude You should have the necessary permissions now to do as I requested above.
claude commentedon Sep 30, 2026
Claude finished @Enkidu93's task in 7m 24s —— View job
Port done and committed locally, but the push was denied
The port is committed on
claude/issue-369-20260930-1927.git pushfailed with403: Permission to sillsdev/machine.py.git denied to github-actions[bot]. The branch is not on the remote, so I have not opened a PR. I did not try another way around the push.What the commit contains (ports machine#472 and machine#521, the PR behind #382):
machine/corpora/convert_usfm_versification_handler.pyaddsConvertUsfmVersificationHandler. It includes the #521 fixes for duplicate mappings and trailing paragraph markers. It is exported frommachine.corpora.ParatextProjectTextUpdaterBase.update_usfmnow converts the USFM to the rows' versification before applying the update. It does this only when the rows' versification differs from the project's.get_rows_versificationis a new module-level function inupdate_usfm_parser_handler.py, the counterpart of the C#GetRowsVersification.tests/corpora/test_convert_usfm_versification_handler.pyholds all 25 C# tests, including the #521 additions.tests/corpora/test_update_usfm_parser_handler.pygains one updater-level test.DefaultParatextProjectSettingsin the test utils now defaults to English instead of Original.ScriptureRefdefaults to English. With the old default, the new conversion step ran in existing update tests and broke 8 of them.Validation:
./local_check.sh --agent-strictended with 873 passed, 3 skipped. That is a local run, not CI.To finish: grant push permission to the workflow's token, or pull the commit from the job's checkout, then re-mention me. I'll push and open the PR with
Closes #369andCloses #382.· Branch
claude/issue-369-20260930-1927(local only)ddaspit commentedon Oct 1, 2026
@claude Try again. You should be able to push now.
claude commentedon Oct 1, 2026
Claude finished @ddaspit's task in 5m 9s —— View job •
claude/issue-369-20261001-1520• [Create PR ➔](https://github.com/sillsdev/machine.py/compare/main...claude/issue-369-20261001-1520?quick_pull=1&title=Issue%20%23369%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23369%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)Port pushed and PR opened
PR: #390 (closes #369 and #382)
The earlier commit wasn't on this branch, so I redid the port. It covers machine#472 and machine#521.
ConvertUsfmVersificationHandler, including the #521 fixes for duplicate verses, dropped-verse markers and trailing paragraph markers. It is exported frommachine.corpora.update_usfmconverts to the rows' versification when it differs from the project's. This uses the newget_rows_versificationhelper.DefaultParatextProjectSettingsin the test utils now defaults to English versification. With the old default, 8 existing update tests ran the new conversion and failed../local_check.sh --agent-strict: 873 passed, 3 skipped. This was a local run, not CI.· Branch
claude/issue-369-20261001-1520Convert USFM versification before updating from rows
Convert USFM versification before updating from rows
Convert USFM versification before updating from rows