Skip to content

[claude] Rebuild snapshots when a project without checkpoints opens - #2799

Closed
myieye wants to merge 2 commits into
claude/fwl-opening-dialog-gsfm69from
claude/fwl-opening-dialog-gsfm69-rebuild
Closed

myieye wants to merge 2 commits into
claude/fwl-opening-dialog-gsfm69from
claude/fwl-opening-dialog-gsfm69-rebuild

Conversation

@myieye

@myieye myieye commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

Stacked on #2798. Since #2788 a project written before snapshot checkpoints existed replays its whole history on the first edit or sync, with nothing on screen. This does it when the project opens instead, behind a full-screen "Updating" status, and updates the What's new entry to say so.

  • MigrateDb regenerates snapshots when a db has commits but no checkpoint, before ReconcileModelVersions so that can resume from one. LcmCrdt tells the host through ISnapshotRebuildListener; FwLiteShared turns it into ProjectRebuildEvent, which DotnetProjectView replays from the event-bus cache because a background sync can start the rebuild first.
  • A failed rebuild stays cached in MigrationTasks until restart, same as a failed migration today. Duration is logged, not reported to telemetry.
  • No CI runs while the base is [claude] Add a What's new dialog to FW Lite #2798's branch (fw-lite.yaml only runs PRs against develop); it will run once the base retargets. Locally: OpenProjectRebuildsSnapshotsTests, RegenerateHarmonySnapshotsTests and OpenProjectTests pass, svelte-check and eslint are clean.

Screenshots

Status shown while a dictionary is rebuilt at open``

🤖 Generated with Claude Code

https://claude.ai/code/session_01RHiY7udrAXqHqXUiA6jRZq

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless labels Oct 25, 2026
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69 branch from 5ae2e5f to c8ab404 Compare October 25, 2026 20:39
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69-rebuild branch from b7e61fe to 8aec40f Compare October 25, 2026 20:41
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69 branch from c8ab404 to d63352e Compare October 25, 2026 20:45
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69-rebuild branch from 8aec40f to dcbae3f Compare October 25, 2026 20:46
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69 branch from d63352e to d495848 Compare October 25, 2026 21:09
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69-rebuild branch from dcbae3f to 079f07c Compare October 25, 2026 21:11
Since the Harmony checkpoint upgrade (#2788) a project written before
checkpoints existed replays its whole history on the first edit or sync,
with nothing on screen. Do it in MigrateDb instead, before
ReconcileModelVersions so that can resume from a checkpoint, and tell
the UI through a new ISnapshotRebuildListener / ProjectRebuildEvent so
DotnetProjectView can show a full-screen "Updating" status meanwhile.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RHiY7udrAXqHqXUiA6jRZq
@myieye
myieye force-pushed the claude/fwl-opening-dialog-gsfm69-rebuild branch from 079f07c to 705a1f0 Compare October 25, 2026 21:23
# Conflicts:
#	frontend/viewer/src/lib/whats-new/WhatsNewDialog.svelte
#	frontend/viewer/src/locales/en.po
#	frontend/viewer/src/locales/es.po
#	frontend/viewer/src/locales/fr.po
#	frontend/viewer/src/locales/id.po
#	frontend/viewer/src/locales/ko.po
#	frontend/viewer/src/locales/ms.po
#	frontend/viewer/src/locales/sw.po
#	frontend/viewer/src/locales/vi.po
@myieye myieye closed this Oct 26, 2026

myieye commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

[Claude, autonomous]

Superseded by #2812 (a major model version instead of a custom check).


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants