Repository navigation
[claude] Give each LcmCrdt test fixture its own media cache folder - #2794
Conversation
Fixtures shared <cache>/<project code> and deleted it on dispose, so a parallel fixture could delete the folder while another was saving a file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
🔩 FW Lite Core
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe fixture now appends a GUID-named subdirectory to Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the main change: assigning each LcmCrdt test fixture its own media cache folder. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The description states that each LcmCrdt test fixture now gets its own ProjectPath and media cache folder, deleted on dispose, to stop parallel tests from deleting each other's media files. It also no… Full details: Description check
-
Explanation
The description states that each LcmCrdt test fixture now gets its own ProjectPath and media cache folder, deleted on dispose, to stop parallel tests from deleting each other's media files. It also notes a change to MediaTestsBase so ErrorMessage is asserted before Result. Both points match the raw summary of MiniLcmApiFixture changes and the objectives of PR
#2794. The description is specific and on-topic, so it passes.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit hops beside the cache,
A fresh new folder greets the day.
When tests are done, it clears the trail,
Then tucks its little paws away.
The burrow’s neat for next-time play.
Comment @coderabbitai help to get the list of available commands.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Configure<LcmCrdtConfig> runs before the kernel's PostConfigure, so the folder no longer depends on registration order. Delete it after disposing services, drop MediaTests' now-redundant project code, and assert ErrorMessage before Result so a failed save shows the exception in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Claude, autonomous]
Each LcmCrdt test fixture gets its own ProjectPath (and so its own media cache folder), deleted on dispose. Before, fixtures shared and deleted one media folder per project code, so parallel tests could delete each other's files mid-save (flaked PictureTests on #2757).
Error.🤖 Generated with Claude Code