Skip to content

remove SigMFGenerator from repository - #164

Merged
Teque5 merged 1 commit into
mainfrom
feature/remove-siggen
Oct 19, 2026
Merged

Teque5 merged 1 commit into
mainfrom
feature/remove-siggen

Conversation

@Teque5

@Teque5 Teque5 commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This was a good idea but after some consideration
it was out of scope for the work here.

This was a good idea but after some consideration
it was out of scope for the work here.
@Teque5
Teque5 requested a review from 777arc October 19, 2026 15:52
@Teque5 Teque5 self-assigned this Oct 19, 2026
@Teque5 Teque5 added the enhancement New feature or request label Oct 19, 2026
@777arc 777arc changed the title remote SigMFGenerator from repository remove SigMFGenerator from repository Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removal is consistent across implementation, exports, tests, and documentation, with no identified blocking issues.

No open issues 🎉

What changed in this PR

Removes synthetic signal generation from sigmf-python because it is outside the project’s scope.

Changes:

  • Removes SigMFGenerator, its exception, exports, tests, and documentation.
  • Updates the file-writing example and archive-test comment to reference sigmf.fromarray.
  • Bumps the package version to 1.15.0.
File Description
tests/​test_siggen.py Deletes generator tests.
tests/​test_archive.py Updates a comment to reference fromarray.
sigmf/​sigmffile.py Replaces the generator-based documentation example.
sigmf/​siggen.py Deletes the generator implementation.
sigmf/​error.py Removes the generator exception.
sigmf/​__init__.py Removes generator exports and bumps the version.
docs/​source/​siggen.rst Deletes the generator guide.
docs/​source/​index.rst Removes the generator navigation entry.
docs/​source/​api.rst Removes the generator API entry.

Review effort: Balanced

@Teque5
Teque5 merged commit 87b809f into main Oct 19, 2026
11 checks passed
@Teque5
Teque5 deleted the feature/remove-siggen branch October 19, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants