Repository navigation
NCD archive fixes - #162
Merged
Merged
Conversation
* When creating an NCD archive, the NCD file is included within the archive. There will be no sigmf-data, but the NCD will be the recording. * Archiving a metadata-only file now raises * Fixed bugs related to header/trailing byte offsets within NCD files * Raises when header/trailing bytes exceed the dataset size * Fixed capture byte boundary tests that silently passed due to typo * Refactored capture tests into `test_capture.py` * Moved shared test data into `conftest.py` * increment to v1.14.0
777arc
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main change
other related stuff
test_capture.pyconftest.pyrelated issues & notes
v1.14.0