Repository navigation
feat(sdk): expose shared browser detection for scripts and agents - #33
Conversation
|
Review follow-up summary The three review findings belong to the independent fix PRs, and their signed follow-up commits are already pushed:
These fixes are also present in Revalidated on the combined branch: 36/36 unit tests, 13/13 real-Chrome SDK integration tests (no skips), ESLint, This PR remains draft pending prerequisite integration and maintainer agreement on the package namespace/API. No npm package has been published. There are currently no review comments on this feature PR. |
|
感谢这份详尽的提案。 方向接受:同意将检测引擎抽成可复用的 Node.js SDK/CLI 包,用 Playwright 驱动真实浏览器。 合并前需要确认的几点:
其他方面(API 接口、private-network 策略、观察窗口默认值)都在可接受范围内。 |
|
感谢确认。建议使用 @stackprism/sdk,CLI 命令继续保留 stackprism;npm scope 和发布权限由项目维护者控制。我会基于最新 main rebase,补齐现有 Playwright 页面在导航前建立网络观察的能力及 agent 使用文档,完成全部验证后标记 ready for review。 |
Move the existing page detector, rule normalizer and precompiler without introducing a second matching engine. Keep extension invocation semantics and add cooperative timing checks for bounded SDK use. Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
Expose caller-owned detectPage and isolated scanUrl operations with structured errors and cancellation. Reuse the extension header matcher for bounded subresource samples with endpoint attribution. Package ESM declarations and bundled rules; cover ownership, navigation, response limits, timeouts and CLI streams in browser integration tests. Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
Keep default tests offline with sanitized Bing fixtures. Provide an opt-in live baseline that distinguishes required evidence drift from failed observation without freezing variable technology counts or timing. Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
e6e1cb6 to
a15bc12
Compare
|
Sorry @Jacobinwwey, your pull request is larger than the review limit of 150,000 diff characters |
Signed-off-by: aliyun1121003339 <jacob.hxx.cn@outlook.com>
|
已完成并标记 ready for review。
采用 @stackprism/sdk,可执行命令仍为 stackprism。包元数据指向上游仓库,scope 与发布权限由维护者控制;本次未发布 npm。 已 rebase 到 58cf3c9,同时保留上游 Vue Devtools 误报修复。相关 bugfix 不再出现在本 PR diff 中。此次仅为落实 rebase 使用精确旧 SHA 的 force-with-lease;后续 CI 修正均为追加的 DCO sign-off 提交。 这轮补齐的实际 agent 缺口:
验证:36/36 单元测试、22/22 真实浏览器 SDK/CLI 测试(无跳过);lint、vue-tsc、扩展构建、文档构建、格式和 diff 检查通过。实际 tarball 在仓库外离线安装,通过严格 NodeNext 类型编译(无 skipLibCheck)与 SDK/observePage/CLI 浏览器实测。Bing 2026-10-18 实测 8/8,HTTP 200,38 条响应、零 skipped/failed。 最终 HEAD:06f1cba。Linux 与 Windows 远端 CI 均通过: https://github.com/setube/stackprism/actions/runs/39083399594 。fork 的 integration/agent-cli-sdk 已同步;完整契约见 packages/stackprism/README.md。 |
|
已合并(e16c1a5),谢谢。本地 Windows + Chrome 又跑了一遍:单测 36/36、SDK 浏览器测试 22/22、扩展构建正常,规则产物和合并前逐字节一致。 |
1. Context & Motivation (Context)
Rebased onto upstream/main 58cf3c9, including merged #30–#32 and the upstream Vue Devtools false-positive correction. Those fixes are outside this PR's diff.
2. Implementation Details (Implementation)
3. Testing Strategies (Validation)