Skip to content

Add force-non-host setting to allow installing non-host toolchains - #16

Merged
osalmi merged 1 commit into
mainfrom
force-non-host
Sep 11, 2026
Merged

osalmi merged 1 commit into
mainfrom
force-non-host

Conversation

@oherrala

@oherrala oherrala commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

New(er) rustup thinks Windows on amd64 can't run i686 toolchains so we might need to force it if and when GitHub Actions runners update to latest version. I already saw CI randomly failing due to this.

See https://github.com/rust-lang/rustup/wiki/Non-host-toolchains

@oherrala
oherrala force-pushed the force-non-host branch 6 times, most recently from 886e6ac to c2433e3 Compare September 10, 2026 11:22
@oherrala
oherrala marked this pull request as ready for review September 10, 2026 12:28
@oherrala
oherrala requested a review from osalmi September 10, 2026 12:28
@oherrala oherrala added the enhancement New feature or request label Sep 10, 2026
Comment thread action.yml Outdated
TOOLCHAIN: ${{ inputs.toolchain }}
PROFILE: ${{ inputs.profile }}
COMPONENTS: ${{ inputs.components }}
FORCE_NON_HOST: ${{ inputs.force-non-host }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all action inputs are strings, we should enforce that no arbitrary strings can be passed.

Suggested change
FORCE_NON_HOST: ${{ inputs.force-non-host }}
FORCE_NON_HOST: ${{ case(inputs.force-non-host == 'true', 'true', 'false') }}

@oherrala
oherrala marked this pull request as draft September 11, 2026 06:30
@oherrala
oherrala marked this pull request as ready for review September 11, 2026 06:33
@oherrala
oherrala requested a review from osalmi September 11, 2026 06:46
@osalmi
osalmi merged commit e4524f3 into main Sep 11, 2026
8 checks passed
@osalmi
osalmi deleted the force-non-host branch September 11, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants