Skip to content

fix(deps): patch vulnerable dependencies (axios, follow-redirects, zod, handlebars, markdown-it, js-yaml, brace-expansion) - #1055

Open
chmaltsp wants to merge 1 commit into
mainfrom
security-sweep/npm-audit-fix
Open

chmaltsp wants to merge 1 commit into
mainfrom
security-sweep/npm-audit-fix

Conversation

@chmaltsp

@chmaltsp chmaltsp commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Lockfile-only targeted update (ranges already allow the fixed versions; CI doesn't regenerate the lockfile).

Resolved: axios 1.21.0 (runtime), follow-redirects 1.16.2 (runtime), handlebars 4.7.10 (critical), markdown-it 14.3.3, js-yaml 3.15.2/4.3.2, brace-expansion, fast-copy.

Not addressed (needs a human):

  • zod (GHSA-mrhx-c7xc-m3w5, high, dev): only zod 3.25.76 via @seamapi/blueprint 1.10.0. The fix needs blueprint >= 1.12.0, which is published only to npm.pkg.github.com; CI installs can't authenticate to it (first attempt of this PR failed with E401). Also a zod 3→4 override would be a major bump.
  • minimatch / glob (moderate, dev): fixes are major bumps (minimatch 11, glob 14) via typedoc/typescript-eslint.
  • tj-actions/changed-files alert (Add test with fake seam connect #7) in automerge.yml: workflow edits out of scope.

Verified locally: typecheck, lint, 176 tests pass.

🤖 Generated with Claude Code

@chmaltsp
chmaltsp requested a review from a team as a code owner November 7, 2026 01:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T01:06:13.957680Z dbcaaf1 PR opened
🔒 Security Review ✅ Completed 2026-11-07T01:06:24.303212Z dbcaaf1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbcaaf1ab4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package-lock.json Outdated
"resolved": "https://registry.npmjs.org/@seamapi/blueprint/-/blueprint-1.10.0.tgz",
"integrity": "sha512-XyP6zvbhv5naWEa9T9utNLi3FVVmvUB1Htih/IjUqS3Uz0FrIIBWy7Myk5+s4uylEt+wTdtSBaA1fGOF/6ILmA==",
"version": "1.12.0",
"resolved": "https://npm.pkg.github.com/download/@seamapi/blueprint/1.12.0/e72f21582831d9be77804b63aafcc9cf48b7e2cc",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore registry URLs that allow unauthenticated installs

In a clean environment without GitHub Packages credentials, npm ci now fetches this package—and @seamapi/smith at line 1090—from npm.pkg.github.com, whose npm packages require authentication even when public. The repository's normal setup action runs npm ci while configuring only https://registry.npmjs.org and provides no NODE_AUTH_TOKEN (.github/actions/setup/action.yml:22-39), so CI and unauthenticated developer installs will fail before tests run; keep these dependencies resolved through the public npm registry or configure GitHub Packages authentication for every install path.

Useful? React with 👍 / 👎.

@chmaltsp

chmaltsp commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

All CI checks green except Vercel, which is also failing on main (pre-existing, unrelated). Not auto-merged: first live sweep run, no human-merge history yet.

This branch had an error being deployed

1 failed deployment
Preview — 9ca57387 Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant