Repository navigation
docs: fix broken links in examples and implementation guide - #337
Merged
Merged
Conversation
Signed-off-by: Satvik Mishra <Satvikmishra.ipu146183@maims.ac.in>
mathieu-benoit
self-requested a review
October 13, 2026 23:28
mathieu-benoit
approved these changes
Oct 13, 2026
mathieu-benoit
left a comment
mathieu-benoit
left a comment
Contributor
There was a problem hiding this comment.
Good catch, @SatvikMishra08! Thanks! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation?
A link check of docs.score.dev found four links that return 404.
What does this change do?
/docs/examples/frontend-and-backend.md, which 404s on the site. It now usesrelref, like the Community link in the same list.dnsprovisioner link pointed to.../score-compose/template/dns-with-url/, which doesn't exist. It now goes to.../score-compose/template/dns-with-route/, the page for10-dns-with-url.provisioners.yaml. The frontend-and-backend score-compose tab already links there.provisioning.goandconvert.golinks were relative paths (./internal/...), so they resolved against docs.score.dev. They now point at those files inscore-spec/score-implementation-sample.What is your testing strategy?
I checked every new target: the docs pages return 200, and the two Go files exist on the sample repo's
mainbranch.Is this related to any issues?
No.
Have you read the Contributing Guidelines?