Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require six characters in
RGBColor.from_string()before converting the RGB components. Inputs such as12345and00000000currently produce a color instead of rejecting the invalid length.This matches the existing six-character validation of
ST_HexColorRGB. Uppercase and lowercase six-character values remain supported.Fixes #1151.
Tests
Tests use pytest 8.4.1 and pyparsing 3.2.3. Latest pyparsing 3.3.3 blocks collection through deprecated calls in existing test helpers; no helper or dependency changes are included.
Repository-wide Ruff reports the same 95 diagnostics on the unmodified base and this branch (the diagnostic signatures match). The optional strict Pyright check is also not clean: 19,963 errors on the base and 19,956 on this branch. Neither is claimed as passing repository-wide.
AI assistance was used for this fix and tests.