Repository navigation
fix: HasRateLimits counts cached responses against the rate limit - #30
Merged
Sammyjo20 merged 5 commits intoOct 15, 2026
Merged
Conversation
Contributor
Author
|
fixes saloonphp/saloon#519 |
Contributor
Author
|
@Sammyjo20, can you review this? |
Member
|
Hey @maks-oleksyuk I will review it for you within the next couple of weeks. |
Sammyjo20
reviewed
Oct 15, 2026
Sammyjo20
reviewed
Oct 15, 2026
Sammyjo20
approved these changes
Oct 15, 2026
Member
|
Thanks @maks-oleksyuk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
HasCachingandHasRateLimitsare used together, cache hits are incorrectly counted toward the limit. This causes delays even when no actual API requests have been made.