Push benchmark results to gh-pages in a single push - #488
Merged
Merged
Conversation
Each store step pushed to gh-pages, so GitHub Pages was deployed twice per run and the first deployment was always cancelled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because each Benchmark run pushes to
gh-pagesonce pergithub-action-benchmarkstep, so GitHub Pages is deployed twice and the first deployment is always cancelled.Detail
The second step now pushes both results at once. Since that step skips fetching
gh-pages, it cannot recover from a push rejected by a concurrent run, so Benchmark runs share aconcurrencygroup. As a result, a pending run is replaced when another commit lands on master, and some intermediate commits may have no benchmark result.Verification
On my fork, a run with this change pushed to
gh-pagesonce and deployed GitHub Pages once.🤖 Generated with Claude Code