Ignore EACCES when unlinking a tempfile from the finalizer - #82
Merged
Merged
Conversation
On Windows, File.unlink raises Errno::EACCES while another handle still holds the file open. Tempfile#unlink already ignores that, but FinalizerManager#call only rescued ENOENT, so the exception escaped from the GC finalizer and was reported on stderr. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Redefining the method warns under RUBYOPT=-w, which CI uses, and the test expects nothing on stderr. Prepending a module leaves the original method in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, when another handle still holds a tempfile open at GC time,
Tempfile::FinalizerManager#callgetsErrno::EACCESfromFile.unlinkand the exception leaks to stderr as "Exception in finalizer".Tempfile#unlinkalready ignoresEACCES, so I made the finalizer do the same.This is a forward-port of ruby/ruby#19029 (ruby/ruby@75d5467039 and ruby/ruby@b5245a5d33). The second commit stubs
File.unlinkwith a prepended module instead of redefining it, so the test stays quiet underRUBYOPT=-w.Generated with Claude Code