Repository navigation
Fix numeric symbol overlays in compressed positions - #98
Open
infinitesniper wants to merge 2 commits into
Open
infinitesniper wants to merge 2 commits into
infinitesniper wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compressed position reports currently return
a–jliterally as the symbol table identifier. Decode them as numeric overlays0–9, as specified in APRS101 chapter 20 (printed page 91), while preserving primary/alternate tables and alphabetic overlays. Fixes #93.Adds two regression tests to the existing position test file: all ten numeric overlays, and unchanged primary, alternate, and alphabetic identifiers.
Validation on Windows / Python 3.12.14:
inspect.getargspec, which is unavailable on Python 3.12.git diff --checkpasses.