Skip to content

refactor: simplification - #160

Merged
rustatian merged 1 commit into
masterfrom
refactor/simplification
Oct 8, 2026
Merged

rustatian merged 1 commit into
masterfrom
refactor/simplification

Conversation

@rustatian

Copy link
Copy Markdown
Member

Reason for This PR

Remove duplicate worker command setup.

Description of Changes

  • Use one command factory for standalone workers and pools. Remove the duplicate factory and its cached command state.
  • Pass optional command arguments directly to exec.CommandContext for workers and startup commands.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 17:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The refactor preserves existing behavior while removing redundant command setup.

Review effort: Balanced
Findings: None

What changed in this PR

Simplifies worker and startup command creation by consolidating command factories and removing redundant state.

Changes:

  • Uses customCmd for standalone workers and pools.
  • Removes cached command arguments and duplicate factory types.
  • Passes optional arguments directly to exec.CommandContext.
File Description
plugin.go Unifies worker and pool command creation.
internal.go Consolidates command factories and simplifies argument handling.
init.go Simplifies startup command and environment construction.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (214a12b) to head (d45fe96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   90.00%   92.45%   +2.45%     
==========================================
  Files           4        4              
  Lines         180      159      -21     
==========================================
- Hits          162      147      -15     
+ Misses         18       12       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian rustatian self-assigned this Oct 8, 2026
@rustatian
rustatian merged commit 6e60760 into master Oct 8, 2026
9 checks passed
@rustatian
rustatian deleted the refactor/simplification branch October 8, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants