Repository navigation
[java] Enforce warning-free builds - #1535
Merged
Merged
Conversation
bgentry
changed the title
Java quality checks succeed while repeating intentional test-resource warnings and shaded archive warnings on every PR. Keep `-Xlint:all`, suppress only the test methods that hold workers or subscriptions open for their lifetime, and reject unsuppressed compiler warnings. Merge dependency license and notice text in both executable archives, generate one manifest, and exclude dependency module descriptors and signatures. Preserve multi-release dependency classes with the matching manifest entry. Run Maven through a shared Make wrapper that streams its output and rejects plugin warnings while preserving command failures. Cover warning output on both streams, ordinary output, and failing command exit codes with focused regression checks. Record the language-prefix convention for PR titles and commit subjects so port-specific changes identify their scope without repeating it.
bgentry
force-pushed
the
bg/java-build-warnings
branch
from
October 24, 2026 22:15
d4b06da to
0890328
Compare
bgentry
enabled auto-merge (squash)
October 24, 2026 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java quality checks currently succeed while repeating intentional test-resource warnings and shaded-JAR warnings on every PR. Suppress unused-resource warnings only on the test methods that intentionally hold workers or subscriptions open, keep
-Xlint:all, and make unsuppressed compiler warnings fatal.Merge dependency license and notice text in both executable JARs, generate one manifest, and exclude dependency module descriptors and signatures. Mark the archives as multi-release so their version-specific dependency classes remain usable.
Run Maven through a shared Make wrapper that streams its output and rejects remaining Maven warnings while preserving command failures. Local checks and CI use the same targets. Focused regression checks cover warning output on both streams, ordinary application logs, and command exit codes.
Document language prefixes for port-specific PR titles and commit subjects in
AGENTS.md, with no redundant language names in the rest of the title.