Repository navigation
Add Java transactional checkpoints, dynamic periodic jobs, and worker timeouts - #1532
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 680431556d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6804315 to
8f8e4eb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
🤖 This review was written by Claude at Blake's request.
The three features work and the docs agree with the code. I found one checkpoint bug that can skip work, and some behaviors that differ from Go and are not in DIFFERENCES.md.
Each inline comment has a label:
- Major: wrong behavior. Fix before merge.
- Minor: fix or document. Does not block merge alone.
- Nit: small. Your decision.
We want the ports to be fully compatible. An idiomatic Java API is good, but behavior must agree with Go or be listed in DIFFERENCES.md. Comments marked "difference from Go" show where it does not.
One problem is older than this PR and needs a separate issue. On SQLite, the completion query merges river:resumable_cursor with jsonb_patch, where Postgres replaces the value. A cursor for a completed step can stay in the row, and that step runs again.
The branch has conflicts with master in java/API.md, Plugin.java, and Workers.java.
… timeouts After we were missing some mainline features from Ruby, I had Codex do another couple passes on Java code to see if anything had been missed there. It's nowhere near as bad, but here we bring in a few additions: * Persist resumable steps and cursors alongside application transactions. * Expose `PeriodicJobBundle` for managing schedules on a running worker. * Support per-job timeout overrides during execution and stuck-job rescue. Cover rollback, registration lifecycle, cancellation, and rescue behavior, and update the API documentation and feature inventory.
8f8e4eb to
2f29d0b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@bgentry Feedback addressed. Could you take another look? |
|
Thx! |
After we were missing some mainline features from Ruby, I had Codex do
another couple passes on Java code to see if anything had been missed
there. It's nowhere near as bad, but here we bring in a few additions:
PeriodicJobBundlefor managing schedules on a running worker.Cover rollback, registration lifecycle, cancellation, and rescue behavior,
and update the API documentation and feature inventory.