OCaml rewatch performance and immutable interfaces - #8680
Draft
fhammerschmidt wants to merge 35 commits into
Draft
fhammerschmidt wants to merge 35 commits into
fhammerschmidt wants to merge 35 commits into
Conversation
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
This was referenced Sep 26, 2026
This was referenced Sep 26, 2026
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
fhammerschmidt
force-pushed
the
rewatch-ocaml-consolidated
branch
from
September 26, 2026 17:58
9a5ae61 to
bf921de
Compare
fhammerschmidt
changed the base branch from
rewatch-ocaml
to
immutable-compiled-interfaces
September 26, 2026 17:58
fhammerschmidt
changed the base branch from
immutable-compiled-interfaces
to
codex/stabilize-rewatch-tests
September 26, 2026 17:59
fhammerschmidt
added this pull request to stack #8668
September 26, 2026 17:59
fhammerschmidt
removed this pull request from stack #8668
September 26, 2026 18:04
fhammerschmidt
changed the base branch from
codex/stabilize-rewatch-tests
to
master
September 26, 2026 18:05
fhammerschmidt
added this pull request to stack #8681
September 26, 2026 18:08
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the OCaml Rewatch experiment into one reviewable stack, with one commit for each previously opened PR and the follow-up implementation work on top.
The changes improve incremental build performance and make the project the compiler's lifetime boundary. Rewatch now reuses compiler sessions, signatures, and runtime CMIs where possible, tracks build freshness and compiler configuration explicitly, and supports an immutable representation of compiled interfaces behind
REWATCH_FROZEN_VALUES=1.The latest follow-up work completes the build lifecycle changes and keeps compatibility file copies explicit. The normal build path avoids legacy source and generated-output copies; compatibility fixtures can opt in with
REWATCH_COMPAT_COPIES=1. Compiler metadata records this mode so changing it invalidates stale artifacts correctly.Commit structure
Validation
make checkformatmake testmake test-rewatchSupersedes
#8671, #8672, #8673, #8675, and #8676 are represented in this single review. This PR is stacked directly on #8653 (
rewatch-ocaml), which remains the separate “Rewrite Rewatch in OCaml” review.