Support PHP 7.4 to 8.5 - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes jack installable and runnable natively across PHP 7.4 to 8.5, so it can be required directly in projects on older PHP. Inspired by TomasVotruba/class-leak#91, now that entropy/entropy runs on 7.4.
Source backport (7.4 syntax, still valid up to 8.5)
readonlyremoved, constructor property promotion expanded to explicit typed propertiesconst string) moved to plain constantsnew DateTimeImmutable(...)->diff(...)(PHP 8.4 chaining) split into two statementstimeout: 120onProcess::fromShellCommandline()moved to positionalsymfony/polyfill-php80added forstr_contains/str_starts_withDistribution
composer.jsonphpconstraint lowered from>=8.4to>=7.4symfony/processwidened to^5.4 || ^6.4 || ^7.0 || ^8.1, so 7.4 resolves against Symfony 5.4 LTSdowngraded_release.yaml,bare_run.yaml,build/,scoper.php,prefix-code.sh,full-tool-build.shTests and CI
Testsworkflow: matrix 7.4, 8.2, 8.5 running PHPUnit and a CLI smoke run, plus a parallel-lint job on 7.4 and 8.5php74so it keeps the source at 7.4 syntaxExisting
Code Analysisworkflow (PHPStan, ECS, Rector) stays on PHP 8.4.PHPUnit, PHPStan, ECS, Rector and parallel-lint all pass locally.