Replace nette/utils and webmozart/assert with entropy - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slim down direct prod dependencies by reusing what the already-required
entropy/entropyprovides.Changes
entropy/entropyto^0.4.17- this version shipsEntropy\Validation\Assertnette/utilsfromrequire:Nette\Utils\Json->Entropy\Utils\Json(decode already returns array, dropped thetruearg)Nette\Utils\FileSystem->Entropy\Utils\FileSystem(dropped the trailingnullmode arg)Nette\Utils\Strings::match/replace->Entropy\Utils\Regex::match/replacewebmozart/assertfromrequire:fileExists,allIsInstanceOfmap directly toEntropy\Validation\AssertkeyExistshas no entropy equivalent, replaced with anarray_key_existsguard throwingShouldNotHappenExceptionDirect prod requires go from 5 to 3. Both dropped packages remain available transitively via dev tooling.
Notes worth a look
Regex::matchreturns[]on no match (nette returnednull), so null checks became empty-array / isset guards.Entropy\Utils\FileSystem::writedoes not create parent directories (nette did), so addedensureDirectoryExists()before writing the cache file inComposerOutdatedResponseProvider.PHPUnit, PHPStan (level 8), ECS and Rector all pass locally.