Repository navigation
Conversation
aslafy-z
force-pushed
the
fix/chromecast-season-episode-index
branch
from
October 22, 2026 18:57
f62f7a8 to
8b987f2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3274.
ResultEpisode.indexis assigned across seasons before episodes are grouped. The result screen passes that global index toCastHelper.startCasttogether with only the selected season/dub group's list. On later seasons, the helper can return before sending a media load request because the index is out of bounds; an in-range index can also select the wrong episode metadata.Look up the selected episode by ID in the exact list sent to Cast, and pass that position instead. Return if the episode is missing.
This changes only the result screen's Cast index selection. The existing link selection, resume position and Cast queue handling are retained.
Validation
ad44a64f0cd660433ffc84994369c13336ae4015with this fix.git diff --checkpasses.Download the validated test APK and full corresponding source. That APK additionally uses a separate package, label and version suffix to allow side-by-side installation; those packaging changes are not included in this PR.