Skip to content

Update Dimensions API types - #5252

Merged
Abbondanzo merged 1 commit into
abbo/rn-docs-stack-event-subscriptionfrom
abbo/rn-docs-stack-dimensions
Sep 27, 2026
Merged

Abbondanzo merged 1 commit into
abbo/rn-docs-stack-event-subscriptionfrom
abbo/rn-docs-stack-dimensions

Conversation

@Abbondanzo

Copy link
Copy Markdown
Contributor

Updates the Dimensions reference to use DimensionsPayload, DisplayMetrics, and DisplayMetricsAndroid instead of deprecated ScaledSize.

@meta-cla meta-cla Bot added the CLA Signed label Sep 25, 2026
@Abbondanzo
Abbondanzo changed the base branch from main to abbo/rn-docs-stack-event-subscription September 25, 2026 16:46
@Abbondanzo
Abbondanzo added this pull request to stack #5254 September 25, 2026 16:46
@Abbondanzo
Abbondanzo force-pushed the abbo/rn-docs-stack-dimensions branch from bc226fc to 2fae9a4 Compare September 25, 2026 16:52

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we probably need to backport all the way down. 😄

But I can do this in a separate PR, while looking at origin of this, I stumbled upon my PR which was adjusting those types in flow in 0.66:

@Abbondanzo
Abbondanzo force-pushed the abbo/rn-docs-stack-dimensions branch from 2fae9a4 to adc125c Compare September 27, 2026 20:42
@Abbondanzo
Abbondanzo removed this pull request from stack #5254 September 27, 2026 23:26
@Abbondanzo
Abbondanzo force-pushed the abbo/rn-docs-stack-dimensions branch from adc125c to c98c619 Compare September 27, 2026 23:26
@Abbondanzo
Abbondanzo added this pull request to stack #5255 September 27, 2026 23:26
@Abbondanzo
Abbondanzo force-pushed the abbo/rn-docs-stack-dimensions branch from c98c619 to d2c2ea2 Compare September 27, 2026 23:27
@Abbondanzo
Abbondanzo merged commit 71a9baa into main Sep 27, 2026
12 checks passed
@Abbondanzo
Abbondanzo deleted the abbo/rn-docs-stack-dimensions branch September 27, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants