Repository navigation
feat(preview): prepare stable 0.2.0 with reliable local rendering - #9
Merged
Merged
Conversation
Preserve the current loading UI while adding accessible dialog controls, focus restoration, keyboard activation and mobile safe-area sizing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chaxus
force-pushed
the
feat/ranui-ranuts-upgrade
branch
from
October 19, 2026 02:40
f66f9c7 to
f81bb8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] Local verification and independent code review passed; merge after the new GitHub checks pass. Preserve the individual commits and use rebase merge.
Summary
Prepare
@ranui/preview0.2.0 while preserving automaticr-previewregistration and existing URL attributes. Reconcile this PR's keyboard/mobile improvements with the current loading UI, add passive manual registration and enforced opt-in Office read-only mode, isolate concurrent loads/dialogs, and replace the old PDF renderer with a complete local PDF.js distribution.Fixes #1
Fixes #3
Fixes #6
PR #8 already resolved the public event issue (#7). Issue #4 stays open because its original Word file has not been supplied.
Risk Analysis
Design Decisions
/manualregisters only when called and allows a custom tag.document:*API with exact iframe source/origin checks, transferring a browser File without base64 for modern hosts.npmenvironment.Code Concerns
Independent review found one modal stacking/Escape defect; both reproductions and the fix are included in
650727e. No remaining P1/P2 findings. Prior global declaration packaging issues are replaced by strict installed-consumer checks. No new credentials are included.Verification
Conclusion basis: Verified.
Coverage details and reproducible live commands: verification report. Not covered: the unavailable original Issue #4 document, older browsers, and direct CJK-cMap/JPX fixture rendering.