Repository navigation
feat(preview): preserve edits and add bounded PDF rendering - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE]
Independent review findings have been fixed and re-reviewed. The changes preserve existing editable Office defaults and eager PDF completion; virtual PDF rendering is opt-in.
Summary
Risk Analysis
Design Decisions
Code Concerns
No unresolved review findings. The slow-modern negotiation, readonly read/ACK boundaries and reconnect cleanup were fixed with failing-before/passing-after regressions. The original Issue #4 sample is still unavailable; this PR does not claim that exact document is fixed.
Verification
Conclusion basis: Verified.
See docs/verification-0.3.0.md for coverage and limits. PDF caps bound active canvas allocations, not total PDF.js/process memory.