Repository navigation
Conversation
sort skipped the write for elements that were already in place. The spec writes every sorted value back with Set(obj, j, v, true), so a read-only receiver such as a String or a frozen array must throw, and setters must see each write. Always write the value back. This made no measurable difference when sorting a large already-sorted array. Fixes: quickjs-ng#1736
saghul
reviewed
Oct 24, 2026
| goto exception; | ||
| } | ||
| if (JS_SetPropertyInt64(ctx, obj, n, array[n].val) < 0) { | ||
| n++; |
Contributor
There was a problem hiding this comment.
Looks like we could rewrite the loop to unconditionally increment n on every run now?
| /* Array.prototype.sort writes every sorted value back with Set(..., true), | ||
| even ones that are already in place. */ | ||
|
|
||
| function throwsTypeError(f) { |
Contributor
There was a problem hiding this comment.
We already have assertThrows, please use that.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1736
sort skipped writing elements that were already in place, so
Array.prototype.sort.call("aa")and sorting a frozen, already sorted array didn't throw. Now every element is written back like the spec says. No measurable slowdown on a 200k element presorted array.