Repository navigation
Conversation
Array.fromAsync destructured the result of next() without checking that it was an object. A primitive like 0 has no `done`, so the loop never ended. The spec throws a TypeError in that case. It also looked up `next` on every step, while the spec reads it once when getting the iterator. Read `next` once, throw on non-object results and regenerate the precompiled builtin. Fixes: quickjs-ng#1769
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1769
next()returning a primitive now rejects with a TypeError instead of looping forever, andnextis read once like the spec says. Touches the same loop as #1596 but doesn't overlap with its close logic.