Repository navigation
Fix pre-reset callback for sessions that are not logged on - #1346
Open
6democratickim9 wants to merge 1 commit into
Open
6democratickim9 wants to merge 1 commit into
6democratickim9 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
============================================
+ Coverage 70.79% 70.81% +0.02%
Complexity 2270 2270
============================================
Files 161 161
Lines 9077 9077
Branches 1192 1192
============================================
+ Hits 6426 6428 +2
+ Misses 2198 2196 -2
Partials 453 453 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call
ApplicationExtended.onBeforeSessionReset()fromSession.reset()even when the session is disconnected or not yet logged on.
The callback runs before the message store is reset. Logged-on sessions
retain the existing Logout handshake.
Fixes #327
Tests
and logged-on sessions.
skipBundlePlugin,minimal-fix-latestand Javadoc generation skipped.