Repository navigation
Conversation
Author
|
The Read the Docs failure is from four Locally, all 339 doctest examples pass on both main and the fixed code. Read the Docs treats the warnings as errors, so its build is still failing; the upstream test workflows await approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general bilinear calculation recovers
sfrom the y coordinates after solvingt. Horizontal corner edges make the y equation singular. With projection roundoff, the denominator can instead be tiny and return an apparently valid but incorrect weight.Recover
sfrom x coordinates, using the separation between the selected left and right corners. This fixes a 13x13 affine field resampled to a 7x9 geographic target: 12 of 63 output cells currently differ from the directly evaluated field, by up to 1.73. The regression checks the complete output.Independent replays also check original packed NCEP temperatures through NumPy and Dask/xarray against a SciPy solution of both coordinate equations, plus an irregular SSMIS swath in LAEA projection. All checked values agree after the change on current dependencies and NumPy 1.26. The two existing helper expectations change from NaN to 0.5 because their valid solution is now obtained before the fallback.