Repository navigation
Conversation
Author
|
The Read the Docs failure is from four Locally, all 339 doctest examples pass on both main and the fixed code. Read the Docs treats the warnings as errors, so its build is still failing; the upstream test workflows await approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumpyBilinearResampler.resample()raisesTypeErrorfor integer data withfill_value=None, andValueErrorwithfill_value=np.nan. The temporary corner array tries to store the output fill before interpolation converts the values to floating point.Use the existing dtype-safe fill helper for corner slicing, while preserving the requested fill for the final output. This follows the conversion already used by the base resampler. For example, this now returns the expected interpolated values as a masked array:
Validation includes signed/unsigned integer regressions with one and two bands, masked and NaN output, and lookup reuse. Eight previously crashing packed-int16 NCEP reanalysis configurations finish with the same complete output as the floating input; existing controls remain unchanged. This preserves the current interpolation algorithm.