Repository navigation
Conversation
Signed-off-by: Don Yin <Don_Yin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bucket containing
[NaN, -7, 3]currently returnsNaNfromget_maxandget_abs_maxwithskipna=True, whileget_min(..., skipna=False)returns-7instead of propagating the NaN.This keeps NaNs behind valid values in the descending sort and reuses the existing missing-bin mask for
skipna=False. Empty and all-NaN buckets keep their current behavior; no fill-value semantics are changed.The new cases cover all three methods, both
skipnasettings, three chunk sizes, Dask arrays and xarray wrappers, and verify that constructing the result stays lazy. They also check valid, empty, all-NaN, and out-of-area samples.Each row contains six measured cases: three chunk sizes × two input wrappers. On the unchanged base, 18 of the 36 new cases fail; with the fix, all 36 pass.
Tests run:
pytest -q pyresample/test/test_bucket.py: 77 passed.pre-commit run --files pyresample/bucket/__init__.py pyresample/test/test_bucket.py: Ruff, whitespace checks, Bandit, mypy and isort passed.git diff --check: passed.Tests added
Tests passed
Fully documented: restores the existing documented
skipnabehavior.