Skip to content

gh-158322: Tidy docstrings in turtle module - #158281

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:turtle/tidy-docstrings-round-1
Sep 28, 2026
Merged

StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:turtle/tidy-docstrings-round-1

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

This is the first round of what will probably be quite a few PRs, as I want to keep the diff in each one reasonably small.

With the introduction of turtle-translations, I’d like to improve the existing docstrings so that they produce better translations. Along the way, this PR also includes a handful of ad hoc refactors that I noticed while working through the module.

These could reasonably be classified as churn, however, the turtle module is, frankly, quite messy in places. I think these changes improve readability and, as a result, maintainability, so I intend to tidy up similar issues.

They should also have relatively little impact on useful Git history, since the majority of the affected lines date back to the original port in 97cf99f.

If there are no comments, I plan to merge this next Thursday.

@m-aciek m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment thread Lib/turtle.py
@StanFromIreland StanFromIreland changed the title Tidy docstrings in turtle module gh-158322: Tidy docstrings in turtle module Sep 28, 2026
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 28, 2026
@StanFromIreland
StanFromIreland merged commit 4e9ea68 into python:main Sep 28, 2026
68 of 69 checks passed
@StanFromIreland
StanFromIreland deleted the turtle/tidy-docstrings-round-1 branch September 28, 2026 08:42
@miss-islington-app

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@StanFromIreland

Copy link
Copy Markdown
Member Author

Thanks for the review!

@miss-islington-app

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e9ea689fec273b9f848a648a62eba74a0216dfe 3.13

@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158324 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 28, 2026
@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158325 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 28, 2026
@bedevere-app

bedevere-app Bot commented Sep 28, 2026

Copy link
Copy Markdown

GH-158326 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 28, 2026
StanFromIreland added a commit that referenced this pull request Sep 28, 2026
StanFromIreland added a commit that referenced this pull request Sep 28, 2026
(cherry picked from commit 4e9ea68)

Co-authored-by: Stan Ulbrych <stan@python.org>
hugovk pushed a commit that referenced this pull request Sep 28, 2026
…) (#158324)

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-refactor Code refactoring (with no changes in behavior)

Projects

Development

Successfully merging this pull request may close these issues.

2 participants