Skip to content

gh-158241: Prevent double release of assembler byte writers #158242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpyu001 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −8
Open

gh-158241: Prevent double release of assembler byte writers #158242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375e1e4
Prevent double release of assembler byte writers
lpyu001 Sep 26, 2026
8bf2dc2
Let assemble_free() handle initialization failures
lpyu001 Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-09-26-23-44-44.gh-issue-158241.NZ9OSU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a crash and possible code object corruption following a
:exc:`MemoryError` while compiling Python code.
11 changes: 3 additions & 8 deletions Python/assemble.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,22 +68,17 @@ assemble_init(struct assembler *a, int firstlineno)
a->a_lineno = firstlineno;
a->a_bytecode_writer = PyBytesWriter_Create(DEFAULT_CODE_SIZE);
if (a->a_bytecode_writer == NULL) {
goto error;
return ERROR;
}
a->a_linetable_writer = PyBytesWriter_Create(DEFAULT_CNOTAB_SIZE);
if (a->a_linetable_writer == NULL) {
goto error;
return ERROR;
}
a->a_except_table_writer = PyBytesWriter_Create(DEFAULT_LNOTAB_SIZE);
if (a->a_except_table_writer == NULL) {
goto error;
return ERROR;
}
return SUCCESS;
error:
PyBytesWriter_Discard(a->a_bytecode_writer);
PyBytesWriter_Discard(a->a_linetable_writer);
PyBytesWriter_Discard(a->a_except_table_writer);
return ERROR;
}

static void
Expand Down
Loading