Conversation
Preserve active attach waiters across successive stop-the-world pauses. Adapt the resume transition to the 3.14 stop-the-world implementation and include the regression test and free-threaded test helper. (cherry picked from commit f156510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of gh-152826, merged as f156510, for gh-151518.
A tight loop of stop-the-world pauses can repeatedly suspend a thread trying to reattach after sleeping, preventing it from returning and stopping the loop. This was found during intentional
numba-cudaGC stress on many-core machines. The fix preserves active attach waiters across successive pauses so they have a chance to run.This branch predates gh-157839, so the waiter-aware resume operation is a private helper in
pystate.c. The attachment changes, regression test, and guard that avoids blocking waits on WASI are carried over from the merged fix.Validation:
test_stop_the_world: all 16 passed in the ordinary GIL build and all 13 available tests passed on WASI, using this branch's SDK 24 and Wasmtime 38.0.3 toolchain.CI note: the macOS free-threaded rerun passed after an IDLE SIGINT interruption on the first run. Both Windows ARM64 jobs fail before compilation because the runner lacks the requested Visual Studio v143 toolset. The unmodified 3.14 parent has the same failures on the same runner image.