Skip to content

docs(saml): describe browser-bound callback flow - #607

Merged
nijel merged 1 commit into
masterfrom
saml
Oct 29, 2026
Merged

nijel merged 1 commit into
masterfrom
saml

Conversation

@nijel

@nijel nijel commented Oct 26, 2026

Copy link
Copy Markdown
Member

The security fix changes how SAML POST callbacks retain SameSite sessions and makes unsolicited responses opt-in. Document the browser return, strategy response headers, and upgrade implications for integrators.

Clarify that integrations implement the header hook with their own response API; core does not assume a particular response object shape.

Refs python-social-auth/social-app-django#1207
Refs WeblateOrg/weblate#22394

@nijel nijel self-assigned this Oct 26, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T15:43:15.660360Z 1b39ff9 New commits
🔒 Security Review ✅ Completed 2026-10-26T18:40:50.541316Z f7b1de0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 Python Social Auth | 🛠️ Build #35446779 | 📁 Comparing 1b39ff9 against latest (da62b04)

  🔍 Preview build  

4 files changed
± security.html
± strategies.html
± backends/openid.html
± backends/saml.html

The security fixes require callbacks to match the initiating browser session. Document the SAML browser return and unsolicited-response opt-in, OpenID rejection of session identifiers, and the response-header strategy hook.

Explain removal of session-restoration strategy methods and the required custom-backend migration for the next major core release.
@nijel
nijel merged commit 1649533 into master Oct 29, 2026
6 checks passed
@nijel
nijel deleted the saml branch October 29, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant